feat(exam-homework): add audit report, i18n, error boundaries, and permission hardening

- Add comprehensive audit report for exam and homework module

- Create exam-homework i18n message files (zh-CN + en) and register namespace

- Add permission check to gradeHomeworkSubmissionAction to prevent horizontal privilege escalation

- Add Error Boundary + loading.tsx for 5 key pages (exam build/proctoring, homework assignment/submissions, student assignment)

- Refactor exam-columns to createExamColumns(t) factory for i18n support

- Refactor exam-data-table to manage columns internally via useTranslations

- Replace hardcoded strings with i18n keys in all exam/homework components and pages

- Add getHomeworkSubmissionForGrading data-access for secure grading flow
This commit is contained in:
SpecialX
2026-06-22 16:08:39 +08:00
parent fde711ce46
commit 21c7e65fee
26 changed files with 2059 additions and 463 deletions

View File

@@ -11,16 +11,22 @@ import {
TableHeader,
TableRow,
} from "@/shared/components/ui/table"
import { formatDate } from "@/shared/lib/utils"
import { Progress } from "@/shared/components/ui/progress"
import { ListPagination, computePagination, paginate } from "@/shared/components/ui/list-pagination"
import { formatDate, formatNumber } from "@/shared/lib/utils"
import { getParam, type SearchParams } from "@/shared/lib/search-params"
import { getHomeworkAssignments } from "@/modules/homework/data-access"
import { getTeacherClasses } from "@/modules/classes/data-access"
import { PenTool, PlusCircle } from "lucide-react"
import { PenTool, PlusCircle, AlertCircle } from "lucide-react"
import { getTeacherIdForMutations } from "@/modules/classes/data-access"
import { getTranslations } from "next-intl/server"
export const dynamic = "force-dynamic"
const PAGE_SIZE = 10
export default async function AssignmentsPage({ searchParams }: { searchParams: Promise<SearchParams> }): Promise<JSX.Element> {
const t = await getTranslations("examHomework")
const sp = await searchParams
const rawClassId = getParam(sp, "classId")
const creatorId = await getTeacherIdForMutations()
@@ -36,19 +42,26 @@ export default async function AssignmentsPage({ searchParams }: { searchParams:
const hasAssignments = assignments.length > 0
const className = filteredClassId ? classes.find((c) => c.id === filteredClassId)?.name : undefined
// 分页计算
const { page } = computePagination(sp, PAGE_SIZE)
const total = assignments.length
const totalPages = Math.max(1, Math.ceil(total / PAGE_SIZE))
const currentPage = Math.min(page, totalPages)
const pagedAssignments = paginate(assignments, currentPage, PAGE_SIZE)
return (
<div className="h-full flex-1 flex-col space-y-8 p-8 md:flex">
<div className="flex items-center justify-between space-y-2">
<div>
<h1 className="text-2xl font-bold tracking-tight">Assignments</h1>
<h1 className="text-2xl font-bold tracking-tight">{t("homework.list.title")}</h1>
<p className="text-muted-foreground">
{filteredClassId ? `Filtered by class: ${className ?? filteredClassId}` : "Manage homework assignments."}
{filteredClassId ? t("homework.list.filterByClass", { className: className ?? filteredClassId }) : t("homework.list.description")}
</p>
</div>
<div className="flex items-center gap-2">
{filteredClassId ? (
<Button asChild variant="outline">
<Link href="/teacher/homework/assignments">Clear filter</Link>
<Link href="/teacher/homework/assignments">{t("homework.list.clearFilters")}</Link>
</Button>
) : null}
<Button asChild>
@@ -60,7 +73,7 @@ export default async function AssignmentsPage({ searchParams }: { searchParams:
}
>
<PlusCircle className="mr-2 h-4 w-4" aria-hidden="true" />
Create Assignment
{t("homework.list.create")}
</Link>
</Button>
</div>
@@ -68,11 +81,11 @@ export default async function AssignmentsPage({ searchParams }: { searchParams:
{!hasAssignments ? (
<EmptyState
title="No assignments"
description={filteredClassId ? "No assignments for this class yet." : "You haven't created any assignments yet."}
title={t("homework.list.empty")}
description={filteredClassId ? t("homework.list.emptyFiltered") : t("homework.list.emptyDescription")}
icon={PenTool}
action={{
label: "Create Assignment",
label: t("homework.list.create"),
href:
filteredClassId
? `/teacher/homework/assignments/create?classId=${encodeURIComponent(filteredClassId)}`
@@ -84,36 +97,73 @@ export default async function AssignmentsPage({ searchParams }: { searchParams:
<Table>
<TableHeader>
<TableRow>
<TableHead>Title</TableHead>
<TableHead>Status</TableHead>
<TableHead>Due</TableHead>
<TableHead>Source Exam</TableHead>
<TableHead>Created</TableHead>
<TableHead className="w-[260px]">{t("homework.list.columns.title")}</TableHead>
<TableHead>{t("homework.list.columns.status")}</TableHead>
<TableHead>{t("homework.list.columns.dueAt")}</TableHead>
<TableHead className="w-[180px]">{t("homework.list.columns.submissionRate")}</TableHead>
<TableHead className="text-right">{t("homework.list.columns.averageScore")}</TableHead>
<TableHead className="text-right">{t("homework.list.columns.overdue")}</TableHead>
<TableHead>{t("homework.list.columns.sourceExam")}</TableHead>
<TableHead>{t("homework.list.columns.createdAt")}</TableHead>
</TableRow>
</TableHeader>
<TableBody>
{assignments.map((a) => (
<TableRow key={a.id}>
<TableCell className="font-medium">
<Link
href={`/teacher/homework/assignments/${a.id}`}
className="hover:underline line-clamp-2 max-w-[240px]"
>
{a.title}
</Link>
</TableCell>
<TableCell>
<Badge variant="outline" className="capitalize">
{a.status}
</Badge>
</TableCell>
<TableCell className="text-muted-foreground tabular-nums">{a.dueAt ? formatDate(a.dueAt) : "-"}</TableCell>
<TableCell className="text-muted-foreground truncate max-w-[200px]">{a.sourceExamTitle}</TableCell>
<TableCell className="text-muted-foreground tabular-nums">{formatDate(a.createdAt)}</TableCell>
</TableRow>
))}
{pagedAssignments.map((a) => {
const submissionRate = a.targetCount > 0 ? (a.submittedCount / a.targetCount) * 100 : 0
const hasOverdue = a.overdueCount > 0
return (
<TableRow key={a.id}>
<TableCell className="font-medium">
<Link
href={`/teacher/homework/assignments/${a.id}`}
className="hover:underline line-clamp-2 max-w-[240px]"
>
{a.title}
</Link>
</TableCell>
<TableCell>
<Badge variant="outline" className="capitalize">
{t(`homework.status.${a.status}`)}
</Badge>
</TableCell>
<TableCell className="text-muted-foreground tabular-nums">{a.dueAt ? formatDate(a.dueAt) : "-"}</TableCell>
<TableCell>
<div className="flex items-center gap-2">
<Progress value={submissionRate} className="h-2 w-24" aria-label={t("homework.list.columns.submissionRate")} />
<span className="text-xs text-muted-foreground tabular-nums whitespace-nowrap">
{a.submittedCount}/{a.targetCount}
</span>
</div>
</TableCell>
<TableCell className="text-right tabular-nums">
{a.averageScore !== null ? formatNumber(a.averageScore, 1) : "-"}
</TableCell>
<TableCell className="text-right">
{hasOverdue ? (
<Badge variant="destructive" className="gap-1">
<AlertCircle className="h-3 w-3" aria-hidden="true" />
{a.overdueCount}
</Badge>
) : (
<span className="text-muted-foreground tabular-nums">0</span>
)}
</TableCell>
<TableCell className="text-muted-foreground truncate max-w-[160px]">{a.sourceExamTitle}</TableCell>
<TableCell className="text-muted-foreground tabular-nums">{formatDate(a.createdAt)}</TableCell>
</TableRow>
)
})}
</TableBody>
</Table>
<ListPagination
page={currentPage}
pageSize={PAGE_SIZE}
total={total}
totalPages={totalPages}
basePath="/teacher/homework/assignments"
searchParams={sp}
itemLabel={t("homework.list.pagination.itemLabel")}
/>
</div>
)}
</div>