refactor(attendance,elective): 审计第二轮 — 全量完成 P0/P1 改进项
P0 修复: - 页面层 i18n 全量补齐(admin/teacher/parent/student × attendance/elective) - types.ts 状态标签常量迁移至 constants.ts(i18n key + Badge variant) - 修复 getTranslations 导入路径(next-intl → next-intl/server) P1 改进: - 解耦 parent 模块对 attendance 类型的直接依赖(本地 view-model 类型) - 导出纯函数(computeStats/buildWarnings/buildLotteryRankCase 等) - 统一空状态为 EmptyState 组件 - 清理死代码读 Action(attendance 5 个 + elective 3 个) - 预留监控埋点接口(trackEvent 13 个新事件名) - 补齐骨架屏 loading.tsx(8 个页面) - AlertDialog 替换 window.confirm(student-selection-view) - a11y 改进(aria-label/role/键盘导航) 修复: - AttendanceStatus 从 constants.ts 重导出,消除 types/constants 双源混乱 - buildWarnings 的 Translator 类型改用 ReturnType<typeof useTranslations>
This commit is contained in:
@@ -1,4 +1,5 @@
|
||||
import type { JSX } from "react"
|
||||
import { getTranslations } from "next-intl/server"
|
||||
import { getTeacherClasses } from "@/modules/classes/data-access"
|
||||
import { getClassAttendanceStats } from "@/modules/attendance/data-access-stats"
|
||||
import { AttendanceStatsCard } from "@/modules/attendance/components/attendance-stats-card"
|
||||
@@ -15,6 +16,7 @@ export default async function AttendanceStatsPage({
|
||||
}: {
|
||||
searchParams: Promise<SearchParams>
|
||||
}): Promise<JSX.Element> {
|
||||
const t = await getTranslations("attendance")
|
||||
const sp = await searchParams
|
||||
|
||||
const classId = getParam(sp, "classId")
|
||||
@@ -27,12 +29,12 @@ export default async function AttendanceStatsPage({
|
||||
return (
|
||||
<div className="h-full flex-1 flex-col space-y-8 p-8 md:flex">
|
||||
<div>
|
||||
<h1 className="text-2xl font-bold tracking-tight">Attendance Statistics</h1>
|
||||
<p className="text-muted-foreground">View class attendance statistics.</p>
|
||||
<h1 className="text-2xl font-bold tracking-tight">{t("title.teacherStats")}</h1>
|
||||
<p className="text-muted-foreground">{t("description.teacherStats")}</p>
|
||||
</div>
|
||||
<EmptyState
|
||||
title="No classes"
|
||||
description="You don't have any classes yet."
|
||||
title={t("stats.noClasses")}
|
||||
description={t("stats.noClassesDescription")}
|
||||
icon={BarChart3}
|
||||
className="border-none shadow-none"
|
||||
/>
|
||||
@@ -53,8 +55,8 @@ export default async function AttendanceStatsPage({
|
||||
return (
|
||||
<div className="h-full flex-1 flex-col space-y-8 p-8 md:flex">
|
||||
<div>
|
||||
<h1 className="text-2xl font-bold tracking-tight">Attendance Statistics</h1>
|
||||
<p className="text-muted-foreground">View class attendance statistics and trends.</p>
|
||||
<h1 className="text-2xl font-bold tracking-tight">{t("title.teacherStats")}</h1>
|
||||
<p className="text-muted-foreground">{t("description.teacherStats")}</p>
|
||||
</div>
|
||||
|
||||
<AttendanceStatsClassSelector
|
||||
@@ -68,14 +70,14 @@ export default async function AttendanceStatsPage({
|
||||
<>
|
||||
<AttendanceStatsCard stats={summary.stats} />
|
||||
<div>
|
||||
<h2 className="mb-4 text-lg font-semibold">Student Records</h2>
|
||||
<h2 className="mb-4 text-lg font-semibold">{t("stats.studentRecords")}</h2>
|
||||
<AttendanceRecordList records={summary.studentRecords} />
|
||||
</div>
|
||||
</>
|
||||
) : (
|
||||
<EmptyState
|
||||
title="No data"
|
||||
description="No attendance data available for this class."
|
||||
title={t("stats.noData")}
|
||||
description={t("stats.noDataDescription")}
|
||||
icon={BarChart3}
|
||||
className="border-none shadow-none"
|
||||
/>
|
||||
|
||||
Reference in New Issue
Block a user