refactor: fix all P0/P1/P2 bugs and architecture issues

Bug fixes (from bugs/ directory):

- Fix cross-module DB queries in 9 modules (homework, grades, parent, diagnostic, elective, proctoring, notifications, scheduling, classes) by routing through data-access functions

- Fix shared/lib <-> auth circular dependency via new session.ts module

- Fix divide-by-zero guard in grades data-access

- Fix audit export data truncation (paginated fetch for full datasets)

- Fix missing transactions in homework grading and elective lottery

- Fix missing revalidatePath in course-plans actions

- Fix frontend permission checks using requirePermission instead of requireAuth

- Fix dashboard role routing using session.user.roles

- Fix student auth pattern (migrate getDemoStudentUser to users module)

- Fix ActionState return type handling in components

Code quality fixes:

- Remove 60+ as type assertions (replace with type guards)

- Remove non-null assertions (use optional chaining or explicit checks)

- Convert dynamic imports to static imports (grades, diagnostic)

- Add React.cache() wrapping for read functions

- Parallelize independent queries with Promise.all

- Add explicit return types to 30+ arrow functions

- Replace any with unknown + type guards

- Fix import type for type-only imports

- Add Zod validation schemas for classes and diagnostic modules

- Extract duplicate code (normalizeRoleName, normalizeBcryptHash, logger IP extraction)

- Add console.error to silent catch blocks

- Fix permission naming consistency (exam:proctor_read -> exam:proctor:read)

Architecture doc sync:

- Update 004_architecture_impact_map.md and 005_architecture_data.json

- Update management-modules-audit.md for P0-7 cross-module fix

Moved deleted proctoring event route to deletes/ folder.

src/modules/elective/data-access.ts

@@ -14,7 +14,6 @@ import {
 import type { DataScope } from "@/shared/types/permissions"
 
 import type {
-  ElectiveCourseStatus,
   ElectiveCourseWithDetails,
   GetElectiveCoursesParams,
 } from "./types"
@@ -114,7 +113,7 @@ export const getElectiveCourses = cache(
       const conditions: SQL[] = []
       if (params?.status)
         conditions.push(
-          eq(electiveCourses.status, params.status as ElectiveCourseStatus)
+          eq(electiveCourses.status, params.status)
         )
       if (params?.gradeId) conditions.push(eq(electiveCourses.gradeId, params.gradeId))
       if (params?.subjectId)
@@ -133,7 +132,8 @@ export const getElectiveCourses = cache(
       ).orderBy(desc(electiveCourses.createdAt))
 
       return rows.map(mapCourseRow)
-    } catch {
+    } catch (error) {
+      console.error("getElectiveCourses failed:", error)
       return []
     }
   }
@@ -147,7 +147,8 @@ export const getElectiveCourseById = cache(
         .limit(1)
       if (!row) return null
       return mapCourseRow(row)
-    } catch {
+    } catch (error) {
+      console.error("getElectiveCourseById failed:", error)
       return null
     }
   }
@@ -234,7 +235,8 @@ export async function getSubjectOptions(): Promise<{ id: string; name: string }[
       .from(subjects)
       .orderBy(asc(subjects.order), asc(subjects.name))
     return rows.map((r) => ({ id: r.id, name: r.name }))
-  } catch {
+  } catch (error) {
+    console.error("getSubjectOptions failed:", error)
     return []
   }
 }