refactor: fix all P0/P1/P2 bugs and architecture issues

Bug fixes (from bugs/ directory):

- Fix cross-module DB queries in 9 modules (homework, grades, parent, diagnostic, elective, proctoring, notifications, scheduling, classes) by routing through data-access functions

- Fix shared/lib <-> auth circular dependency via new session.ts module

- Fix divide-by-zero guard in grades data-access

- Fix audit export data truncation (paginated fetch for full datasets)

- Fix missing transactions in homework grading and elective lottery

- Fix missing revalidatePath in course-plans actions

- Fix frontend permission checks using requirePermission instead of requireAuth

- Fix dashboard role routing using session.user.roles

- Fix student auth pattern (migrate getDemoStudentUser to users module)

- Fix ActionState return type handling in components

Code quality fixes:

- Remove 60+ as type assertions (replace with type guards)

- Remove non-null assertions (use optional chaining or explicit checks)

- Convert dynamic imports to static imports (grades, diagnostic)

- Add React.cache() wrapping for read functions

- Parallelize independent queries with Promise.all

- Add explicit return types to 30+ arrow functions

- Replace any with unknown + type guards

- Fix import type for type-only imports

- Add Zod validation schemas for classes and diagnostic modules

- Extract duplicate code (normalizeRoleName, normalizeBcryptHash, logger IP extraction)

- Add console.error to silent catch blocks

- Fix permission naming consistency (exam:proctor_read -> exam:proctor:read)

Architecture doc sync:

- Update 004_architecture_impact_map.md and 005_architecture_data.json

- Update management-modules-audit.md for P0-7 cross-module fix

Moved deleted proctoring event route to deletes/ folder.

src/modules/classes/data-access-students.ts

@@ -1,19 +1,20 @@
 import "server-only";
 
 import { cache } from "react"
-import { and, asc, desc, eq, inArray, sql, type SQL } from "drizzle-orm"
+import { and, asc, eq, inArray, sql, type SQL } from "drizzle-orm"
 
 import { db } from "@/shared/db"
 import {
   classes,
   classEnrollments,
-  homeworkAssignmentTargets,
-  homeworkAssignments,
-  homeworkSubmissions,
   subjects,
-  exams,
   users,
 } from "@/shared/db/schema"
+import {
+  getAssignmentIdsForStudents,
+  getHomeworkSubmissionsForAssignments,
+  getPublishedHomeworkAssignmentsWithSubject,
+} from "@/modules/homework/data-access-classes"
 import type {
   ClassStudent,
   StudentEnrolledClass,
@@ -29,31 +30,12 @@ export const getStudentsSubjectScores = cache(
   async (studentIds: string[]): Promise<Map<string, Record<string, number | null>>> => {
     if (studentIds.length === 0) return new Map()
 
-    // 1. Find assignments targeted at these students
-    const assignmentTargets = await db
-      .select({ assignmentId: homeworkAssignmentTargets.assignmentId })
-      .from(homeworkAssignmentTargets)
-      .where(inArray(homeworkAssignmentTargets.studentId, studentIds))
-
-    const assignmentIds = Array.from(new Set(assignmentTargets.map(t => t.assignmentId)))
+    // 1. Find assignments targeted at these students (via homework module data-access)
+    const assignmentIds = await getAssignmentIdsForStudents(studentIds)
     if (assignmentIds.length === 0) return new Map()
 
-    // 2. Get assignment details including subject from linked exam
-    const assignments = await db
-      .select({
-        id: homeworkAssignments.id,
-        createdAt: homeworkAssignments.createdAt,
-        subjectId: exams.subjectId,
-        subjectName: subjects.name
-      })
-      .from(homeworkAssignments)
-      .innerJoin(exams, eq(homeworkAssignments.sourceExamId, exams.id))
-      .leftJoin(subjects, eq(exams.subjectId, subjects.id))
-      .where(and(
-        inArray(homeworkAssignments.id, assignmentIds),
-        eq(homeworkAssignments.status, "published")
-      ))
-      .orderBy(desc(homeworkAssignments.createdAt))
+    // 2. Get published assignment details including subject from linked exam (via homework module)
+    const assignments = await getPublishedHomeworkAssignmentsWithSubject({ assignmentIds })
 
     // 3. Filter subjects (exclude PE, Music, Art)
     const excludeSubjects = ["体育", "音乐", "美术"]
@@ -70,17 +52,8 @@ export const getStudentsSubjectScores = cache(
     const targetAssignmentIds = Array.from(subjectAssignments.values())
     if (targetAssignmentIds.length === 0) return new Map()
 
-    // 4. Get submissions for these assignments
-    const submissions = await db
-      .select({
-        studentId: homeworkSubmissions.studentId,
-        assignmentId: homeworkSubmissions.assignmentId,
-        score: homeworkSubmissions.score,
-        createdAt: homeworkSubmissions.createdAt,
-      })
-      .from(homeworkSubmissions)
-      .where(inArray(homeworkSubmissions.assignmentId, targetAssignmentIds))
-      .orderBy(desc(homeworkSubmissions.createdAt))
+    // 4. Get submissions for these assignments (via homework module)
+    const submissions = await getHomeworkSubmissionsForAssignments(targetAssignmentIds)
 
     // 5. Map back to subject scores per student
     const studentScores = new Map<string, Record<string, number | null>>()
@@ -95,11 +68,11 @@ export const getStudentsSubjectScores = cache(
       const subject = assignmentSubjectMap.get(s.assignmentId)
       if (!subject) continue
 
-      if (!studentScores.has(s.studentId)) {
-        studentScores.set(s.studentId, {})
+      const existing = studentScores.get(s.studentId)
+      const scores = existing ?? {}
+      if (!existing) {
+        studentScores.set(s.studentId, scores)
       }
-
-      const scores = studentScores.get(s.studentId)!
       // Only set if not already set (since we ordered by desc createdAt, first one is latest)
       if (scores[subject] === undefined) {
         scores[subject] = s.score
@@ -183,7 +156,8 @@ export const getStudentClasses = cache(async (studentId: string): Promise<Studen
         .leftJoin(users, eq(users.id, classes.teacherId))
         .where(and(eq(classEnrollments.studentId, id), eq(classEnrollments.status, "active")))
         .orderBy(asc(classes.schoolName), asc(classes.grade), asc(classes.name), asc(classes.homeroom), asc(classes.room))
-    } catch {
+    } catch (error) {
+      console.error("getStudentClasses primary query failed, falling back:", error)
       return await db
         .select({
           id: classes.id,